Release scrub turns upstream author credits into `{{PRINCIPAL_FULL_NAME}}`, so installs credit the installing user

Open
#2,645 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 5 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
backend

Research direction

Start by tracing the release scrub and install-time identity render that transform author and credit lines; the issue does not name their implementation files or tests. Compare the listed files under LifeOS/install/skills/Fabric/Patterns/ with upstream Fabric attribution. Done means third-party credits remain intact after install and update, while references to the user still receive the user's name.

Written by the indexing model from the issue text.

Description

The release scrub replaces the developer's own name with {{PRINCIPAL_FULL_NAME}} in author and credit lines. The install-time identity render then fills in the installing user's name. The result is that every install credits the developer's work to its own user.

Examples in LifeOS/install/skills/Fabric/Patterns/, compared with danielmiessler/fabric:

  • extract_wisdom/README.md:152, extract_article_wisdom/README.md:152, extract_product_features/README.md:152: **Author**: {{PRINCIPAL_FULL_NAME}} (upstream: Daniel Miessler)
  • create_better_frame/system.md:11: Author {{PRINCIPAL_FULL_NAME}} February 24, 2024
  • rate_value/README.md:3: Co-created by {{PRINCIPAL_FULL_NAME}} and <co-author> (upstream: Daniel Miessler and Jason Haddix)
  • show_fabric_options_markmap/system.md:400: By {{PRINCIPAL_FULL_NAME}}.

Because the render runs again on every update, a local fix gets overwritten on the next upgrade.

Suggested fix: exempt third-party attribution from the identity scrub. Fabric patterns and any author or credit lines should keep the real author, and the user's name should only be substituted where a line refers to the user.

Dominant language
TypeScript
Stars
19.9k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from danielmiessler/LifeOS

All issues in danielmiessler/LifeOS

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.