Approval timing issues
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- blockchain, frontend
Research direction
Start by tracing the panel's pending state, the MetaMask transaction completion callback, and the core blockchain polling loop described in the issue. Reproduce approval timing with an unenabled GEN or NEC token, then ensure the panel does not return to the enable screen during approval and reaches the post-approval view once approval is detected.
Written by the indexing model from the issue text.
Description
Situation
- The user has not enabled their token (GEN or NEC for the respective schemes)
- The user presses the 'Enable' button on the 'Please enable' screen shown
- The panel goes into the pending state
Issues
- Panel can return from the pending view back to the 'Please enable' screen, confusing the user
- The panel will update to post-approval view once the core blockchain polling loop returns new data.
This is due to how async operations are handled - the pending state is set when we start the TX in metamask, and stopped when that returns as done.
This can happen at a different time then the core polling loop, which checks if the user has enabled their token. If they have, it shows the post-approval view in the panel.
Perhaps ideally, we'd see if the transaction returned on the core polling loop.
As a stopgap, you could add in a call to see if the user has approved token after the metamask call, and then return pending after that.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dOrgTech/NectarDAO-Bootstrapper
-
Polish UIMay be free again @cbrzn claimed this 2190 days ago, and no pull request is open. Openenhancement
dOrgTech/NectarDAO-Bootstrapper#36 · 2 assignees ·
-
Text input changes color when selected from dropdownMay be free again @jpkcambridge claimed this 2514 days ago, and no pull request is open. Open
dOrgTech/NectarDAO-Bootstrapper#26 · 1 assignee ·
-
Add base function for all write calls for consistent logging messagesMay be free again @tspoff claimed this 2534 days ago, and no pull request is open. Open
dOrgTech/NectarDAO-Bootstrapper#23 · 1 assignee ·
-
wontfix
Difficulty 4/5 3-5 days Newbie friendliness 25/100
dOrgTech/NectarDAO-Bootstrapper#2 · 1 comment ·
All issues in dOrgTech/NectarDAO-Bootstrapper
Similar issues
-
Add: VIVE TVOpenapproved check:passed streams:add
Difficulty 1/5 Under an hour Newbie friendliness 72/100
iptv-org/iptv#55293 · 1 comment ·
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Fission-AI/OpenSpec#2084 ·
Maintainers usually reply within 2 days
-
Contrib indemnité de départ à la retraite : faire le pont avec le simulateur sur la page génériqueOpenP1
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
SocialGouv/code-du-travail-numerique#7561 ·
Maintainers usually reply within 1 day
-
beginner bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
hiero-ledger/hiero-sdk-js#4517 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
kubernetes-sigs/headlamp#7950 ·
Maintainers usually reply within 3 days