formatUTCWeekNumberISO and formatWeekNumberISO return incorrect results at edge of the year
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- backend
Research direction
The issue identifies formatUTCWeekNumberISO and formatWeekNumberISO in d3-time-format and provides a CodePen reproduction. Read those functions and the related tests, then check the reported year-boundary case; done means both functions return the correct ISO week number at the edge of the year.
Written by the indexing model from the issue text.
Description
These functions work by counting how many Thursdays have occurred up to this date
function formatUTCWeekNumberISO(d, p) {
d = UTCdISO(d);
return pad(utcThursday.count(utcYear(d), d) + (utcYear(d).getUTCDay() === 4), p, 2);
}
Unfortunately the argument d is re-assigned and can cause the year to roll over, so that utcYear(d) returns a different year because UTC is in a different timezone
Codepen: https://codepen.io/28raining/pen/VwqYaKL?editors=1111
Using a separate variable avoids this
function formatUTCWeekNumberISO(d, p) {
var dUTC = UTCdISO(d);
return pad(utcThursday.count(utcYear(d), dUTC ) + (utcYear(d).getUTCDay() === 4), p, 2);
}
- Dominant language
- JavaScript
- Stars
- 338
- Forks
- 100
- Avg merge
- 6h 20m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from d3/d3-time-format
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
d3/d3-time-format#125 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
d3/d3-time-format#123 · 2 comments ·
-
Missing SemesterOpen
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
d3/d3-time-format#103 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
d3/d3-time-format#93 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
d3/d3-time-format#92 ·
All issues in d3/d3-time-format
Similar issues
-
maintenance
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
assistant-ui/assistant-ui#10496 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
ai bug design good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
neomjs/neo-agent-institution#927 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gramps-project/gramps-web#1671 ·
Maintainers usually reply within 1 day
-
bug good first issue priority: P2 status: ready
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
RhinoLink-Tech/data-fabric#502 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
cline/mcp-marketplace#3708 ·