locallibrary: light-mode phrase colours are too faint in the HTML mix report
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start with packages/tokens/colors.json and compare the phrases palette with the light and dark status palettes. Then read crates/locallibrary/src/mix/report.html around phraseColor to see how it reads the --phrase-* variables; check the website mix report too, since it uses the same file. Done means the shared colors include light-mode phrase colors with at least 3:1 contrast against the light background and both reports use them.
Written by the indexing model from the issue text.
Description
Problem
In the report's light mode the verse and bridge phrase strips are about 2:1 against the white page (verse #e8a83c is 2.08:1, bridge #40b8de is 2.30:1). The phrase names are printed below, so no information is lost, but the strips are hard to see. packages/tokens/colors.json has one phrase palette; status has light and dark variants, phrases does not.
What you'd like
Add light-mode phrase colours to packages/tokens/colors.json (same shape as status) with at least 3:1 against the light background, and use them in the report's light theme. The website's mix report reads the same file and has the same issue.
Where
- https://github.com/cutenode/localnetwork/blob/24d3176/packages/tokens/colors.json#L9-L18 (
phrases, one palette) - https://github.com/cutenode/localnetwork/blob/24d3176/packages/tokens/colors.json#L34-L37 (
statuswith light and dark) - https://github.com/cutenode/localnetwork/blob/24d3176/crates/locallibrary/src/mix/report.html#L681-L683 (
phraseColor, reads--phrase-*) - https://github.com/cutenode/localnetwork/blob/24d3176/apps/locallibrary/TODO.md#L332-L333
- Dominant language
- Rust
- Stars
- 0
- Forks
- 0
- Avg merge
- 9h 14m
- Merged PRs (30d)
- 99
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cutenode/localnetwork
-
bug locallibrary: core
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
cutenode/localnetwork#169 ·
Maintainers usually reply within 1 day
-
bug locallibrary: core
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
cutenode/localnetwork#158 ·
Maintainers usually reply within 1 day
-
bug locallibrary locallibrary: core
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
cutenode/localnetwork#137 ·
Maintainers usually reply within 1 day
-
locallibrary: a plugin's export plan adds up the file sizes it reports without an overflow checkOpenbug locallibrary locallibrary: plugins
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
cutenode/localnetwork#133 ·
Maintainers usually reply within 1 day
-
documentation locallibrary locallibrary: plugins
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
cutenode/localnetwork#130 ·
Maintainers usually reply within 1 day
All issues in cutenode/localnetwork
Similar issues
-
bug: workspace access hint suggests a --subject command that fails for hyphen-leading OIDC subjectsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
A-FFI C-Testing D-Straightforward S-Ready
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
docs priority:P3 size:XS
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Appimage ConventionsOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day