Refactor: facilities cell heights
@CameronHamidi is already working on this.
Since Nov 20, 2019.
Assessment
This issue has not been assessed yet.
Description
Currently, each facility detail cell, when calculating the height of all of it combined subviews, manually adds together the estimated line height of each text view. This is inefficient an inacurrate, so these heights should be calculated with NSAttributedString.size().height instead.
- Dominant language
- Swift
- Stars
- 18
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cuappdev/uplift-ios
-
Type: Maintenance
Difficulty 4/5 3-5 days Newbie friendliness 35/100
cuappdev/uplift-ios#266 ·
-
Type: Refactor
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
cuappdev/uplift-ios#233 ·
-
Type: Refactor
Difficulty 4/5 3-5 days Newbie friendliness 25/100
cuappdev/uplift-ios#232 ·
-
Refactor: GymDetailViewController SectionsMay be free again @kevinchan159 claimed this 2513 days ago, and no pull request is open. OpenType: Refactor
cuappdev/uplift-ios#207 · 4 assignees ·
-
Create new Facilities cell for GymDetailViewControllerMay be free again @CameronHamidi claimed this 2516 days ago, and no pull request is open. OpenPriority: High
cuappdev/uplift-ios#203 · 1 assignee ·
All issues in cuappdev/uplift-ios
Similar issues
-
Dictated bullet lists keep the recogniser's commas at the end of every line ("- Milk," "- Eggs,")Openarea:dictation bug good first issue P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
uttrflow/uttrflow-swift#1958 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
521xueweihan/HelloGitHub#3788 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
callstackincubator/appduct#129 ·
Maintainers usually reply within 1 day
-
clawsweeper:not-repro-on-main impact:ux-friction issue-rating: 🦪 silver shellfish P2
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
steipete/CodexBar#4040 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
mozilla-mobile/firefox-ios#35827 ·
Maintainers usually reply within 1 day