Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Refactor: GymDetailViewController Sections

Open
#207 0 comments 0 reactions 4 assignees View on GitHub

@kevinchan159 is already working on this.

Since Nov 10, 2019.

Assessment

This issue has not been assessed yet.

Description

Type: Refactor

Currently, inside GymDetailViewController we define an enum Section follows:

    // MARK: - Private classes/enums
    private struct Section {
        var items: [ItemType]
    }

and then define var sections: [Section] to just be:

self.sections = [
  Section(items: [.hours, .busyTimes, .facilities, .classes([])])
]

This means that what we end up with is just one giant section with 4 cells.

We should change this so that we have 4 sections, with one cell in each. This is will help reduce with the increasingly nested view hierarchy we have

Dominant language
Swift
Stars
18
Forks
3
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cuappdev/uplift-ios

All issues in cuappdev/uplift-ios

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.