[Feature] Presskit SVGs doesn't work well with non-white backgrounds
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start with the License chooser HTML output and compare its referenced Presskit icons, such as https://mirrors.creativecommons.org/presskit/icons/by.svg, with the transparent icons in src/svg/cc/icons. Confirm where the Presskit assets are maintained; done means transparent-center variants are available, with chooser defaults changed only if that is included in scope.
Written by the indexing model from the issue text.
Description
Problem
Presskit SVGs don't work well with non-white backgrounds.
Current behavior on the left and desired behavior on the right.
Description
The SVGs used by the HTML produced by the "License chooser" have a solid white background inside the circle.
The icons are hosted here and are part of the "Presskit" e.g.:
https://mirrors.creativecommons.org/presskit/icons/by.svg
The white background icons from "Presskit" are inconsistent with the icons here (which are transparent):
https://github.com/creativecommons/vocabulary/tree/main/src/svg/cc/icons
I suggest having an extra set of icons in the "Presskit" with transparent centers.
It is probably a good idea to leave the current ones as is for backwards compatibility.
Maybe even use these in the "License chooser" by default moving forward.
Alternatives
Leave everything "as is", but having icons with transparent backgrounds available, we get a web that looks better 😅
Additional context
Maybe also provide SVGs with white "fill color" for dark (themed) websites.
Implementation
- I would be interested in implementing this feature. (but I would need some pointers as to where I can find this "Presskit")
- Dominant language
- HTML
- Stars
- 187
- Forks
- 243
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from creativecommons/creativecommons.org
-
💻 aspect: code 🚦 status: awaiting triage 🛠 goal: fix 🟨 priority: medium
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
💻 aspect: code 🚧 status: blocked 🛠 goal: fix 🟨 priority: medium
Difficulty 5/5 Over a week Newbie friendliness 35/100
creativecommons/creativecommons.org#1424 · 4 comments ·
-
💻 aspect: code 🛠 goal: fix 🟨 priority: medium 🧹 status: ticket work required
Difficulty 4/5 3-5 days Newbie friendliness 45/100
creativecommons/creativecommons.org#1422 · 2 comments ·
-
✨ goal: improvement 🏁 status: ready for work 💻 aspect: code 🟩 priority: low
Difficulty 5/5 Over a week Newbie friendliness 20/100
creativecommons/creativecommons.org#1315 · 1 comment ·
-
[Feature] Unambiguously Grant a Copyright License to CC IconsMay be free again @diyananoory-cc claimed this 422 days ago, and no pull request is open. Open✨ goal: improvement 🏁 status: ready for work 🔒 staff only 🕹 aspect: interface 🟩 priority: low
creativecommons/creativecommons.org#1308 · 2 comments · 3 assignees ·
All issues in creativecommons/creativecommons.org
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
IacobIonut01/ReFra#1433 ·
Maintainers usually reply within 17 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
OREL-group/Project-Management#133 · 1 comment ·
-
项目日志弹出窗尺寸可拉伸功能Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Codex使用可 コード
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ryuki-moro/Nicomaru#209 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day