[Chore] The Workerman minimum version ^5.0 is lower than what the code and docs need
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- build-system
Research direction
Start by comparing the Workerman constraint in composer.json with the version used by CI and the lock file, then review the version-specific notes in docs/deployment.md and docs/logging-monitoring.md. Decide whether to raise the minimum version or add a lowest-version CI job; completion means the chosen path is reflected in the required files and the documented 5.1.4 caveats are removed if Option A is selected.
Written by the indexing model from the issue text.
Description
Problem
composer.json:43 allows workerman/workerman: ^5.0.
But some things in the code and docs need a newer version:
- The 10 MB log cut (
Worker::$logFileMaxSize) exists only from Workerman 5.1.4. docs/deployment.md and docs/logging-monitoring.md now say this. - CI and the lock file test only Workerman 5.2.2.
So a user can install 5.0.x. Then the bundle may behave in a way that the docs do not describe, and no test checks it.
Fix idea
Option A: raise the minimum to ^5.1.4 or ^5.2 (the version that CI tests).
Option B: keep ^5.0 and add a CI job with composer update --prefer-lowest.
Option A is simpler. It changes what users can install, so it needs a CHANGELOG and an UPGRADE.md note.
Done when
- A decision: A or B.
- composer.json, CHANGELOG and UPGRADE.md are updated (A), or the lowest-version CI job is green (B).
- The docs do not need "only from 5.1.4" notes anymore (A).
- Dominant language
- PHP
- Stars
- 2
- Forks
- 3
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 52
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from crazy-goat/workerman-bundle
-
priority:low type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
crazy-goat/workerman-bundle#1189 ·
Maintainers usually reply within 1 day
-
priority:medium type:bug type:security
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
crazy-goat/workerman-bundle#1188 ·
Maintainers usually reply within 1 day
-
priority:medium type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
crazy-goat/workerman-bundle#1182 ·
Maintainers usually reply within 1 day
-
priority:low type:tests
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
crazy-goat/workerman-bundle#1177 ·
Maintainers usually reply within 1 day
-
[Bug] MasterFingerprint::writeTo() leaks the temp file silently when rename() and unlink() both failOpenpriority:low type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
crazy-goat/workerman-bundle#1176 ·
Maintainers usually reply within 1 day
All issues in crazy-goat/workerman-bundle
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/blocks-engine#5003 ·
Maintainers usually reply within 1 day
-
from-cloud mythic tracked
Difficulty 1/5 Under an hour Newbie friendliness 86/100
MythicalLTD/FeatherPanel#459 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug]: PostgreSQL backend: Queue.remove() / Job.remove() never emit the QueueEvents "removed" eventPossibly taken @1AbdullahButt claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
taskforcesh/bullmq#5085 ·
Maintainers usually reply within 1 day
-
area:mesi area:php-extension good first issue priority:low type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
crazy-goat/go-mesi#652 ·
Maintainers usually reply within 1 day