Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

[Bug] Missing static root is still not caught for root_dir, reload and bound arguments

Open
  • Is something wrong?
#977 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
php, symfony
Domain
backend, devops, testing

Research direction

Start with the cited paths src/Worker/ServerWorker.php:157 and src/Http/HttpRequestHandler.php:117, then trace how Runner validates server roots and how the compiler pass obtains service definitions. Add tests for the serve_files root, reload after directory deletion, and roots supplied through defaults or parent/child definitions. Done means missing roots produce one clear error or keep old workers, without a restart loop.

Written by the indexing model from the issue text.

Description

priority:low type:bug

Problem

PR #976 stops start and restart when the root directory of a StaticFilesMiddleware service does not exist. Some cases are still not covered. In these cases the workers restart again and again.

How to see it

  • The old serve_files + root_dir path has the same problem (src/Worker/ServerWorker.php:157, src/Http/HttpRequestHandler.php:117).
  • The server runs, the directory is deleted, then reload (or the file monitor) restarts the workers: the workers fail in a loop.
  • A root set only through _defaults.bind or a parent/child service definition is not seen by the compiler pass.
  • In prod, an old config cache has an old static_roots list until cache:clear.

Fix idea

Check root_dir of every server in Runner too. For reload, keep the old workers or stop with one message. For the definition cases, read the argument after the container is compiled.

Done when

  • serve_files with a missing root_dir stops start with one clear error.
  • A reload with a missing directory does not start a restart loop.
  • Tests for each case.
Dominant language
PHP
Stars
2
Forks
3
Avg merge
39m
Merged PRs (30d)
105

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from crazy-goat/workerman-bundle

All issues in crazy-goat/workerman-bundle

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.