SortableJS is not reinitialised when the grid is redrawn
Maintainers usually reply within 4 days
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with assets/plugins/integrations/sortable.ts and trace how the sortable constructor and DOM updates are handled after the grid is redrawn. Check the payload path involving payload._datagrid_sort, especially when it is absent because only the filter form was submitted. Done means sortable drag-and-drop is reinitialised after redraws and the plugin responsibilities or constructor argument are appropriately separated.
Written by the indexing model from the issue text.
Description
I think the sortable plugin mixes two concerns - updating some DOM after the sortable column headers are clicked and initializing the sortable drag&drop plugin. I think these should be split to separate plugins or at least make the sortable constructor argument optional.
In addition, there is a bug where the sortable is not reinitialised when payload._datagrid_sort is not set in the payload, this is set only when the filter form is submitted.
- Dominant language
- PHP
- Stars
- 297
- Forks
- 214
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 4
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from contributte/datagrid
-
Latte 3.1: "Positional argument after a named argument is deprecated" in templatesPossibly taken @sasule claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
contributte/datagrid#1337 ·
Maintainers usually reply within 4 days
-
Item - detail bug when grid has parent componentPossibly taken @radimvaculik claimed this 109 days ago. OpenT: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
contributte/datagrid#1299 ·
Maintainers usually reply within 4 days
-
Bug? Datagrid TreeView not adding classes on content rowsPossibly taken @radimvaculik claimed this 142 days ago. OpenT: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
contributte/datagrid#1290 · 2 comments ·
Maintainers usually reply within 4 days
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
contributte/datagrid#1335 ·
Maintainers usually reply within 4 days
-
Bug: Missing reset filter buttonPossibly taken @radimvaculik claimed this 84 days ago. OpenT: Bug
Difficulty 3/5 1-2 days Newbie friendliness 65/100
contributte/datagrid#1306 ·
Maintainers usually reply within 4 days
All issues in contributte/datagrid
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
mailcow/mailcow-dockerized#7668 · 5 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
lara-zeus/spatie-translatable#80 ·
Maintainers usually reply within 1 day
-
small
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
uiowa/uiowa#10296 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
asyncapi/modelina#2709 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
My-Little-Forum/mylittleforum#937 ·