WorkflowDef drops maskedFields during JSON deserialization and serialization

Open Beginner friendly
#183 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp

Research direction

Start by reading Conductor.Client.Models.WorkflowDef and its JSON serialization configuration, then compare its properties with the linked server WorkflowDef schema. Add support that preserves maskedFields through deserialization and serialization; the provided minimal reproduction should pass with maskedFields present in the serialized JSON.

Written by the indexing model from the issue text.

Description

Bug

Conductor.Client.Models.WorkflowDef does not expose the server-supported maskedFields property and has no JSON extension-data mechanism. Deserializing and serializing a valid workflow definition therefore silently removes its masking configuration.

Observed with conductor-csharp 3.0.0.

Minimal reproduction

    const string json = """
    {
      "name": "masked-example",
      "version": 1,
      "tasks": [],
      "timeoutSeconds": 60,
      "maskedFields": ["secret"]
    }
    """;

    var definition = JsonConvert.DeserializeObject<WorkflowDef>(json)!;
    var serialized = JObject.Parse(JsonConvert.SerializeObject(definition));

    Assert.NotNull(serialized["maskedFields"]); // Fails

Expected

WorkflowDef should expose and serialize maskedFields, consistently with the server's WorkflowDef schema. Alternatively, unknown properties should be preserved using JsonExtensionData.

Dominant language
C#
Stars
54
Forks
23
Avg merge
5d 9h
Merged PRs (30d)
3

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from conductor-oss/csharp-sdk

All issues in conductor-oss/csharp-sdk

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.