WorkflowDef drops maskedFields during JSON deserialization and serialization
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp
- Domain
- backend-api-design
Research direction
Start by reading Conductor.Client.Models.WorkflowDef and its JSON serialization configuration, then compare its properties with the linked server WorkflowDef schema. Add support that preserves maskedFields through deserialization and serialization; the provided minimal reproduction should pass with maskedFields present in the serialized JSON.
Written by the indexing model from the issue text.
Description
Bug
Conductor.Client.Models.WorkflowDef does not expose the server-supported maskedFields property and has no JSON extension-data mechanism. Deserializing and serializing a valid workflow definition therefore silently removes its masking configuration.
Observed with conductor-csharp 3.0.0.
Minimal reproduction
const string json = """
{
"name": "masked-example",
"version": 1,
"tasks": [],
"timeoutSeconds": 60,
"maskedFields": ["secret"]
}
""";
var definition = JsonConvert.DeserializeObject<WorkflowDef>(json)!;
var serialized = JObject.Parse(JsonConvert.SerializeObject(definition));
Assert.NotNull(serialized["maskedFields"]); // Fails
Expected
WorkflowDef should expose and serialize maskedFields, consistently with the server's WorkflowDef schema. Alternatively, unknown properties should be preserved using JsonExtensionData.
- Dominant language
- C#
- Stars
- 54
- Forks
- 23
- Avg merge
- 5d 9h
- Merged PRs (30d)
- 3
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from conductor-oss/csharp-sdk
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
conductor-oss/csharp-sdk#165 ·
-
Missing WorkflowTaskTypeEnum values: AGENT, GET_AGENT_CARD, CANCEL_AGENT, PULL_WORKFLOW_MESSAGESOpenenhancement
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
conductor-oss/csharp-sdk#161 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
conductor-oss/csharp-sdk#159 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
conductor-oss/csharp-sdk#153 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
conductor-oss/csharp-sdk#143 ·
All issues in conductor-oss/csharp-sdk
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openclaw/openclaw-windows-node#2287 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
area:host area:operations type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
kind:ux needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
elsa-workflows/elsa-foundation#4742 ·
Maintainers usually reply within 1 day
-
priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement good first issue help wanted new-language
Difficulty 2/5 1-3 hours Newbie friendliness 82/100