DirIO module ReadOptions do not work for Windows

Open
#3,167 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
haskell
Domain
backend

Research direction

Start by locating the DirIO module’s ReadOptions definition and the Windows conditional shown in the issue. Check how the listed options are exposed on other platforms and what the Windows-specific id configuration modifier requires. Done means Windows supports the same ReadOptions options without that conditional; the issue names no test, so identify the relevant coverage while reading the module.

Written by the indexing model from the issue text.

Description

type:bug

Need to remove the ifdef:

#if defined(mingw32_HOST_OS) || defined(__MINGW32__)
    -- | Only the default ReadOptions are supported for Windows. Please use "id"
    -- as the configuration modifier.
      ReadOptions
#else
      ReadOptions
    , followSymlinks
    , ignoreMissing
    , ignoreSymlinkLoops
    , ignoreInaccessible
#endif
Dominant language
Haskell
Stars
926
Forks
71
Avg merge
6h 49m
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from composewell/streamly

All issues in composewell/streamly

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.