Synchronous channel cleanup

Open
#3,064 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
haskell

Research direction

Start by reading the channel shutdown and stream worker code to find where ThreadAbort is sent; the issue does not name specific files or tests. Compare synchronous cancellation, asynchronous abort, and the proposed timeout based hybrid, then identify the behavior and configuration that should be tested. Done means the chosen shutdown mode is implemented and its effect on the current stream action and pending items is verified.

Written by the indexing model from the issue text.

Description

We throw ThreadAbort exception to running thread when the channel is stopped. Asynchronous exceptions can cause inadvertent problems because of unclean shutdown of the thread. It may leave the system in inconsistent state unless proper exception handling is implemented by the programmer. To avoid such issues we can also use a synchronous shutdown of streams by setting a flag and letting the thread abort itself. This would stop the thread before the next item in the stream is handled but the current action would not be interrupted. This could lead to delays in aborting the streams but would be safer than async signalling. This could be a config option, perhaps the default and the programmer can choose the other way if needed.

We can also have an option of a hybrid approach where we try to stop the threads synchronously first then after a timeout throw async exceptions.

Dominant language
Haskell
Stars
926
Forks
71
Avg merge
6h 49m
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from composewell/streamly

All issues in composewell/streamly

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.