Make enum out of the parser states (objdump/parser)

Open
#21 2 comments 0 reactions 0 assignees View on GitHub

@phyBrackets is already working on this.

Since Jan 29, 2022.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
compilers

Research direction

Start by inspecting objdump/parser and locating the existing parser-state definitions and transitions. Confirm the complete set of states and their typical handling order, then verify that parser behavior remains unchanged after the states are represented as an enum.

Written by the indexing model from the issue text.

Description

So that it's easier to track which are possible and in what order they're typically handled

Dominant language
C++
Stars
36
Forks
10
Avg merge
36m
Merged PRs (30d)
6

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from compiler-explorer/asm-parser

All issues in compiler-explorer/asm-parser

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.