Typed input and output
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- ruby
- Domain
- backend, distributed-systems
Research direction
Start with lib/temporal/concerns/typed.rb at line 22 and review how activities and workflows currently handle input and output serialization. The issue needs an agreed approach for reusable dry-struct validation, typed outputs, and validation before workflow activation; done should include a defined API and tests for each behavior.
Written by the indexing model from the issue text.
Description
Hi! I am trying to get rid of JSON.parse(input) and JSON.dump(output) in activities/workflows and wanted to define Input and Output classes with dry-struct to define the structure.
Then I found this line in https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/concerns/typed.rb#L22
unless klass.is_a?(Dry::Types::Type)
Now I am stuck on how to make reusable structs with validation for workflow/activity params. I have three questions:
- Does it make sense to change condition in typed.rb to allow dry structs?
- How I can add typed output, so I don't need to serialize and deserialize outputs multiple time?
- Any best practices to validate inputs before activating the workflow?
Any ideas how to solve this?
- Dominant language
- Ruby
- Stars
- 287
- Forks
- 113
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coinbase/temporal-ruby
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
coinbase/temporal-ruby#361 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
coinbase/temporal-ruby#341 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
coinbase/temporal-ruby#328 · 1 comment ·
-
NoMethodError when await_workflow_result is called for long running workflowsPossibly taken @iekundayo claimed this 717 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 45/100
coinbase/temporal-ruby#326 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
coinbase/temporal-ruby#324 · 3 comments · 2 reactions ·
All issues in coinbase/temporal-ruby
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Homebrew/homebrew-cask#295450 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 Half a day Newbie friendliness 72/100
TheOdinProject/curriculum#31479 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
taskcluster/taskcluster#9284 · 1 comment ·
Maintainers usually reply within 1 day
-
Class option relations are appended to the command on every runPossibly taken @auraseb claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100