Unattributed provider complaints count against the receiving organization
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Read services/email/reputation/tasks.py, especially parse_fbl_report and its resolve_fbl_owner path, then inspect services/email/reputation/evaluation.py and the complaints calculation. Trace how unattributed reports reach organization rates and suspension decisions. Done means unattributed reports remain visible to staff but no longer contribute to any organization's complaint rate.
Written by the indexing model from the issue text.
Description
An unattributed provider complaint counts against the organization that owns the FBL inbox. That is relay's own organization, so platform complaints can suspend the receiving side.
When a provider complaint cannot be attributed to a sending organization, parse_fbl_report keeps the organization that owns the inbound FBL address. compute_org_reputation counts every provider report for that organization, with no filter on attribution.
The FBL inbox belongs to the platform. Complaints that relay cannot match therefore accumulate against relay's own organization and feed its complaint rate. The same code path that suspends customers can then suspend that organization, and the receiving side of the platform goes down with it.
Evidence:
services/email/reputation/tasks.py:parse_fbl_reportkeeps the ingest organization whenresolve_fbl_ownerreturnsNoneservices/email/reputation/evaluation.py:complaintscounts provider reports per organization with no attribution requirement
Suggested direction: record unattributed reports with no owner, or with a dedicated platform-review flag. Exclude them from any organization's rate. Keep them visible for staff.
Found during the sandbox-credentials change (#259). This fault is older than that change.
- Dominant language
- Python
- Stars
- 4
- Forks
- 0
- Avg merge
- 2h 40m
- Merged PRs (30d)
- 163
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from codingjoe/relay
-
enhancement real sec
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
codingjoe/relay#410 · 1 comment ·
Maintainers usually reply within 1 day
-
bug side quest
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
bug side quest
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug side quest
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
side quest test
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
Similar issues
-
intake mcp-intake needs-ac needs-human-review priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Ikalus1988/MisakaNet#3848 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
521xueweihan/HelloGitHub#4105 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
igormcsouza/bookloud#54 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
aws-samples/sample-per-model-bedrock#526 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ok-oldking/ok-wuthering-waves#1802 ·
Maintainers usually reply within 2 days