🤖 fix: xum api exits 0 when a procedure returns success: false

Open Beginner friendly
  • Is something wrong?
#7,856 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
api, cli

Research direction

Start by reproducing with xum api calling workspace set-pinned on a workspace that does not exist, then check the shell exit code. The payload does not name the file that maps a procedure's Result to the process exit status, so search the api command's source for where the response is printed. Done when a success: false result exits non-zero and the error message is still printed.

Written by the indexing model from the issue text.

Description

Summary

xum api exits 0 when a procedure returns { success: false, error }. A verifier saw this with workspace set-pinned on a missing workspace, on main before and after #7855. Scripts that check the exit code treat a refused operation as a success.

Expected

The command exits non-zero when the procedure returns a Result with success: false, and it still prints the error.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $297.50

Dominant language
TypeScript
Stars
2.1k
Forks
139
Avg merge
3h 35m
Merged PRs (30d)
950

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from coder/xum

All issues in coder/xum

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.