🤖 refactor: put the MCP modules that agent-loop files import behind Effect services
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
Research direction
Start with the phase 5 plan’s claim 3.5 and the four listed modules: workspaceMcpOverridesService.ts, mcpAppResultStore.ts, mcpServerManager.ts, and agentPlugins/mcpConfig.ts. Trace their imports from aiService.ts and turnRequestBuilder.ts, then inspect the Effect services and Node and test layers added in phase 5. Done means all listed host access goes through those services with behavior and persisted files unchanged, and the phase 5 end check reports only its specified follow-up modules and log.
Written by the indexing model from the issue text.
Description
Summary
Agent-loop files import these modules, and the modules still reach the host directly (fs, os, child_process, writeFileAtomic, a runtime class or a runtime builder). The local/no-host-imports rule checks only the agent-loop files themselves, so it does not see this host access. Phase 5 of the agent-loop refactor does not move these modules: its plan (claim 3.5, decision "reach") keeps one follow-up issue per group. This issue is the MCP group: MCP servers, overrides and app results.
Modules
| Module | Host refs | Host imports | Imported by agent-loop files at |
|---|---|---|---|
src/node/services/workspaceMcpOverridesService.ts |
44 | fs/promises:2 fs:3 runtime/runtimeFactory:15 runtime/runtimeHelpers:16 | aiService.ts:104 turnRequestBuilder.ts:158 |
src/node/services/mcpAppResultStore.ts |
12 | fs/promises:2 utils/fs:15 utils/writeFileAtomic:16 | turnRequestBuilder.ts:87 |
src/node/services/mcpServerManager.ts |
10 | fs/promises:5 runtime/DevcontainerRuntime:88 runtime/RemoteRuntime:89 runtime/runtimeFactory:104 | turnRequestBuilder.ts:149 |
src/node/services/agentPlugins/mcpConfig.ts |
4 | fs:7 fs/promises:8 | turnRequestBuilder.ts:81 |
Total: 4 module(s), 70 uses of host bindings. Counts and lines come from reach.mjs --phase2 and reachRefs.mjs of the phase 5 plan, at ba9e451cab (phase 1 changed no file under src/).
Work
Move the host access of each module behind the Effect services that phase 5 adds (HostFiles, HostPaths, HostProcesses, RuntimeFactory, SessionFiles, SessionLocks), with a Node layer and a test layer, and no change in behavior or persisted files.
Trigger
After phase 5 ends (stacks 5a and 5b merged). Phase 5 end check 7 expects reach.mjs --phase2 to list only the 30 follow-up modules of these 8 issues and log.
Refs
- Phase 5 plan v4 ("Host I/O Services for the Xum Agent Loop", artifact
phase5-plan.html), claim 3.5. - Refs #7207 (the
local/no-host-importsrule and its frozen pairs).
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $31.10
- Dominant language
- TypeScript
- Stars
- 2.1k
- Forks
- 140
- Avg merge
- 4h 57m
- Merged PRs (30d)
- 946
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coder/xum
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
🤖 fix: a Daytona connection test started before a settings save can show the old key as connectedOpen
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
Similar issues
-
[Bug]: Device screenshot fails with 500 on iPhone Duo (Xcode 27.2): serve-sim calls simctl without --displayPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
pingdotgg/t3code#24900 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inu-appcenter/UNIDorm-web#411 ·
Maintainers usually reply within 1 day
-
🐛 bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ranxianglei/billion-context#4720 ·
Maintainers usually reply within 1 day
-
area:arcade game p3-medium ready-for-agent type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
fderuiter/deruiter.dev#2840 ·
Maintainers usually reply within 1 day