[review-low] code-yeongyu/senpi#6726: glob error text for plain and '..' patterns, and UNC prefixes
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- tooling
Research direction
Start in packages/machine-ops/src/files/local-files.ts at splitGlobBase; read the whole function and the tests that exercise it before changing anything. For L2, check how a pattern with no glob syntax is split so the root itself and ../dir/.. produce an error that matches the actual case. For L3, check how path.win32.resolve(sep, ...fixed) treats leading empty segments of a //server/share/* pattern. Done when both cases return correct errors or resolve inside the root, with tests added for the plain, .., and UNC patterns.
Written by the indexing model from the issue text.
Description
Two LOW findings from the review of #6726 at 7d54bb5a64 (receipt code-yeongyu_senpi#6726-7d54bb5a64-1794737883261.md), left open by the LEAD's ruling (L1 was fixed in the PR). Both fail closed: the pattern is refused or searched in a directory inside the root, never outside it.
- L2,
packages/machine-ops/src/files/local-files.ts(splitGlobBase): a pattern with no glob syntax is cut before its last segment. So<root>itself is refused with " is outside the scope root", and..ordir/..are refused with "may not use '..' after a wildcard" although they contain no wildcard. The refusal is right; the error text is wrong for the case. - L3, same function:
resolve(sep, ...fixed)drops the empty leading segments of a Windows UNC pattern, so//server/share/*resolves to the drive-root path\server\share(path.win32.resolve("\\", "", "", "server", "share")gives\server\share). It is refused or searches the wrong directory; it never escapes the root.
- Dominant language
- TypeScript
- Stars
- 517
- Forks
- 163
- Avg merge
- 23h 31m
- Merged PRs (30d)
- 700
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from code-yeongyu/senpi
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
code-yeongyu/senpi#6813 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 66/100
code-yeongyu/senpi#6746 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
code-yeongyu/senpi#6742 ·
Maintainers usually reply within 1 day
-
host ensure fails with EACCES for a second OS user: senpi-rpc-host-locks is shared across usersOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
code-yeongyu/senpi#6738 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
code-yeongyu/senpi#6723 ·
Maintainers usually reply within 1 day
All issues in code-yeongyu/senpi
Similar issues
-
bug(core): JsonOutputKeyToolsParser ignores returnId: truePossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
langchain-ai/langchainjs#12239 ·
Maintainers usually reply within 1 day
-
Board view: the Monitoring column is always empty because compact issue rows drop displayStatusOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
paperclipai/paperclip#21837 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 93/100
lingdojo/kana-dojo#34169 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100