knip: unused export deferredLabel in equivalence-deferred.mjs (from #4751)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 85/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- bun, javascript
- Domain
- tooling
Research direction
Open .agents/skills/senpi-qa/scripts/lib/equivalence-deferred.mjs and remove the export keyword from the deferredLabel const at line 47 so it is module-private. Run bun run knip:check and node --test .agents/skills/senpi-qa/scripts/lib/*.test.mjs to confirm the unused export vanishes and tests pass. Done means knip no longer lists deferredLabel and bun run check passes.
Written by the indexing model from the issue text.
Description
Summary
bun run knip:check on main reports deferredLabel in .agents/skills/senpi-qa/scripts/lib/equivalence-deferred.mjs as an unused export. It is only used inside its own module (by goldenCellVerdict), so the export is dead surface and keeps knip red.
Evidence
- knip output on main (origin/main 09f556dfc9):
(the other finding,Unused exports (2) deferredLabel .agents/skills/senpi-qa/scripts/lib/equivalence-deferred.mjs:47:14discoveryNamesItsServer, is tracked separately in #4933) .agents/skills/senpi-qa/scripts/lib/equivalence-deferred.mjs:47:export const deferredLabel = (entry) => ...; the only reference is line 53 in the same file.git grep -nw deferredLabel origin/mainfinds no importer (tests included).- Added in ed550e248e ("test(senpi-qa): EQ deferred-goldens list for the linux-x64 E25, E28 and E29 cells (P0-05e)"), merged with #4751 (merge c30dc42821).
Fix
Drop export so deferredLabel is module-private. No knip ignore or baseline entry, so coverage does not shrink. Acceptance: knip no longer lists deferredLabel; node --test .agents/skills/senpi-qa/scripts/lib/*.test.mjs and bun run check pass.
Related: #4751, #4933.
Hosted check
Fails the hosted CI check Static checks (its knip:check step: Unused exports: deferredLabel .agents/skills/senpi-qa/scripts/lib/equivalence-deferred.mjs:47:14) on any branch based before the fix.
- Dominant language
- TypeScript
- Stars
- 500
- Forks
- 155
- Avg merge
- 21h 52m
- Merged PRs (30d)
- 699
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from code-yeongyu/senpi
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
code-yeongyu/senpi#5262 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
code-yeongyu/senpi#5255 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
code-yeongyu/senpi#5221 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
code-yeongyu/senpi#5202 ·
Maintainers usually reply within 1 day
-
flaky: jsonl-import "recovers an interrupted durable commit" fails under load (error undefined)Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
code-yeongyu/senpi#5191 ·
Maintainers usually reply within 1 day
All issues in code-yeongyu/senpi
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
enhancement tech debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
privatenumber/tsx#866 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
danielmiessler/LifeOS#2533 ·
Maintainers usually reply within 9 days
-
auto:producer auto:uiux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
fritzprix/libr-agent#2447 ·
Maintainers usually reply within 1 day