Async load zxcvbn.js to use with ember-cli-password-strength
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start with ember-cli-build.js and the existing ember-stripe-elements addon/utils/load-script.js utility. Enable asynchronous loading for ember-cli-password-strength, then determine how the project should provide zxcvbn.js at a project-controlled path instead of the default root URL. Done means async mode is enabled and the library loads successfully without bundling it.
Written by the indexing model from the issue text.
Description
Problem
ember-cli-password-strength, since 2.0.0, has support for asynchronous loading of the zxcvbn.js library.
Since the library is 400k gzipped, it would make sense for us to make use of this.
However, the addon does not provide a framework to actually include the library as part of the project. Instead, it assumes, if aync mode is on, that the library is locaded at ${config.rootUrl}/zxcvbn.js
We need to find a way to deal with this and switch to async mode.
Subtasks
- Turn on async mode for the addon as per instructions, by modifying the app's
ember-cli-build.jsand adding
let app = new EmberAddon(defaults, {
'ember-cli-password-strength': {
bundleZxcvbn: false
}
});
- Provide the library, either at the expected path, or, more likely at our own path, by providing custom async loading facilities, similar to what we do with
ember-stripe-elements
https://github.com/code-corps/ember-stripe-elements/blob/master/addon/utils/load-script.js
- Dominant language
- JavaScript
- Stars
- 120
- Forks
- 75
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from code-corps/code-corps-ember
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
code-corps/code-corps-ember#1616 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
code-corps/code-corps-ember#1613 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
code-corps/code-corps-ember#1612 ·
-
Difficulty: Medium Skill: ember-cli-page-object
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
code-corps/code-corps-ember#1063 · 1 reaction ·
-
greenkeeper
Difficulty 3/5 1-2 days Newbie friendliness 25/100
code-corps/code-corps-ember#1765 · 1 comment ·
All issues in code-corps/code-corps-ember
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
docToolchain/docToolchain#1705 ·
-
Timezone select lists one option per character; duplicate "Failed" reason; shared tracker popover id Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1414 ·
-
bug v2
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelcontextprotocol/inspector#2458 · 1 comment ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
carbon-design-system/ibm-products#9907 ·