Rewrite integration tests for skill-button-test component

Open
#1,621 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
testing

Research direction

Start with tests/integration/components/skill-button-test.js and read how its page object is currently used in each test. Define the shared renderPage() setup above moduleForComponent, then use it in each test with the required hbs selectors. Done means the tests still pass without repeating the page-rendering setup.

Written by the indexing model from the issue text.

Description

Problem

Currently, tests/integration/components/skill-button-test.js doesn't make full use of its page object by not defining a renderPage() function. To dry up the code, you can set a renderPage() function above the moduleForComponent, pass in the needed hbs selectors, and call renderPage() in each test.

References

#1605

Dominant language
JavaScript
Stars
120
Forks
75
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from code-corps/code-corps-ember

All issues in code-corps/code-corps-ember

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.