Rewrite integration tests for reset-password-test component

Open
#1,617 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
testing-qa

Research direction

Open tests/integration/components/password/reset-password-test.js and inspect how each test currently renders the component. Define renderPage() above moduleForComponent with the needed hbs selectors, then use it in each test to remove duplicated setup. Done means the integration tests still pass with the page object handling rendering.

Written by the indexing model from the issue text.

Description

Problem

Currently, tests/integration/components/password/reset-password-test.js doesn't make full use of its page object by not defining a renderPage() function. To dry up the code, you can set a renderPage() function above the moduleForComponent, pass in the needed hbs selectors, and call renderPage() in each test.

References

#1605

Dominant language
JavaScript
Stars
120
Forks
75
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from code-corps/code-corps-ember

All issues in code-corps/code-corps-ember

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.