Refactor task-card.hbs to remove potential bug

Open
#1,586 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Start with task-card.hbs and review the tests implemented in pull request #1488, then read the referenced issue comment for the suspected conditional structure. Done means the template is clearer about the selected/unselected icons and the existing tests continue to pass.

Written by the indexing model from the issue text.

Description

From https://github.com/code-corps/code-corps-ember/pull/1488#issuecomment-350194545

It looks like the selected/unselected icons are "trapped" behind canAssign, or at the very least, written in a way that it appears they are.

I think, with these tests (implemented in #1488) in place now, the task-card.hbs warrants a bit of a refactor to make it clearer.

Dominant language
JavaScript
Stars
120
Forks
75
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from code-corps/code-corps-ember

All issues in code-corps/code-corps-ember

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.