Discussion: Add ability to approve any unapproved project in admin UI
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript
Research direction
Review the admin UI approval flow and the API validation behavior described in the issue, focusing on the approvalRequested and long description conditions. The scope is not decided: determine whether approval should be allowed for any unapproved project with a long description, and confirm the UI and API behave consistently if that decision is made.
Written by the indexing model from the issue text.
Description
Problem
At the moment, only projects with approved: false, approvalRequested: true can be approved, which, in a non-direct way, supports the API requiring the presence of long description for approved projects
- an org owner can create a project without long description
- an admin cannot approve such a project through the UI
- if an admin tries to approve such a project through the API directly, they will get a validation error
- an org owner can request approval once they provide a long description
- an admin can approve such a project both through the UI and the API directly
Really, in the background, this only affects the admins and no one else, so I'm not sure it's worth our time to change anything at the moment, but what we could do, is support approving a project as long as they have a longDescritption, without necessarily being in approvalRequested status
It would take 30 minutes to do, but i'm not sure it's wise or useful, simply because there may be a scenario where an owner might provide an incomplete long description, but not be ready for approval yet.
- Dominant language
- JavaScript
- Stars
- 120
- Forks
- 75
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from code-corps/code-corps-ember
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
code-corps/code-corps-ember#1616 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
code-corps/code-corps-ember#1613 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
code-corps/code-corps-ember#1612 ·
-
Difficulty: Medium Skill: ember-cli-page-object
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
code-corps/code-corps-ember#1063 · 1 reaction ·
-
greenkeeper
Difficulty 3/5 1-2 days Newbie friendliness 25/100
code-corps/code-corps-ember#1765 · 1 comment ·
All issues in code-corps/code-corps-ember
Similar issues
-
bot:ai-assisted component:compact-js status:untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
midnightntwrk/midnight-sdk#403 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
DavidAnson/markdownlint-cli2#940 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#3692 ·
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
Difficulty 2/5 1-3 hours Newbie friendliness 90/100