Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Deprecation: Native dom helpers should not be used as globals in tests anymore

Open
#1,207 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
frontend, testing-qa

Research direction

Start by reviewing the test files and package configuration, then search tests for global find, click, fillIn, visit, and related helpers. Distinguish native DOM helpers from same-named ember-cli-page-object functions, add the ember-native-dom-helpers dependency, and import native helpers in every affected module. Done means no remaining native helper usage relies on globals.

Written by the indexing model from the issue text.

Description

Skill: ember-cli-page-object Skill: Ember.js Skill: JavaScript

Problem

Using native dom helpers as globals is now deprecated in our tests. Instead, we should add a new dependency to our app and import these helpers from it in any tests that need it.

We are leaning away from these anyway, due to relying on ember-cli-page-object, but there are still a couple of places where we do use them.

Subtasks

  • Install depdencency https://github.com/cibernox/ember-native-dom-helpers
  • Search through our tests for usage of the find, click, fillIn, visit and other global functions in this group. Careful not to mistake them for the identically named functions provided by ember-cli-page-object. The culprits we need to fixed are likely used as globals, in tests, directly.
  • In any module that uses them, import them using import { visit, click, find, fillIn } from 'ember-native-dom-helpers';
Dominant language
JavaScript
Stars
120
Forks
75
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from code-corps/code-corps-ember

All issues in code-corps/code-corps-ember

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.