eval(routing): check_regression catches Exception more broadly than its calls raise
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Read evals/routing/check_regression.py, especially the handlers at lines 33, 47, and 67, and identify which exceptions the file reads and json.loads can raise. Narrow each handler to those errors, then check the file’s relevant tests or run the available regression check to confirm expected soft failures still work and unexpected errors are no longer hidden.
Written by the indexing model from the issue text.
Description
evals/routing/check_regression.py (lines 33, 47 and 67) uses except Exception around file reads and json.loads. Those raise OSError, UnicodeDecodeError and json.JSONDecodeError; catching everything can hide a real bug as a soft failure. Narrow each handler to the errors its calls raise.
Found in review of #416 and left out of that PR to keep it small.
- Dominant language
- HTML
- Stars
- 347
- Forks
- 12
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 95
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coco-research/coco
-
bug P2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
coco-research/coco#539 ·
Maintainers usually reply within 1 day
-
bug P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
coco-research/coco#538 ·
Maintainers usually reply within 1 day
-
bug P2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
coco-research/coco#537 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
coco-research/coco#530 ·
Maintainers usually reply within 1 day
-
check-asset-counts: bare 149 tripwire collides with a real active-assets count of 149Possibly taken @aryankalantri claimed this 1 day ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
coco-research/coco#473 ·
Maintainers usually reply within 1 day
All issues in coco-research/coco
Similar issues
-
hive size:simple
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
priority: low server testing
Difficulty 1/5 Under an hour Newbie friendliness 88/100
blamechris/chroxy#9277 ·
Maintainers usually reply within 1 day
-
frontend medium testing
Difficulty 2/5 Half a day Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
DuarteSantos8/openGym#1480 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ranacseruet/vaice#139 ·
Maintainers usually reply within 1 day