test(install): coverage follow-ups from the #387 / #388 reviews

Open
#389 3 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
bash
Domain
cli, testing

Research direction

Start with check-uninstall.sh, check-install-safety.sh, tests/lib/install-home.sh, and check-install-manifest.sh; read each listed follow-up and the related review context from #387 and #388. Implement the test and helper changes in the checklist, then run all four installer checks under /bin/bash 3.2. Done means every box is checked and all four checks pass.

Written by the indexing model from the issue text.

Description

enhancement

Test-only lows from the GLM reviews of the installer manifest (#387) and uninstall (#388) PRs. They were left under the review stop rule; none affects installer behaviour.

  • check-uninstall.sh:
    • Add a skip case where a link's text drifted from the recorded source.
    • Add an uninstall run with managed settings present.
    • Assert every skip carries a string reason, so a skip can't slip through with only restore set.
    • Assert managed_settings == [] under the empty root.
    • Guard $WORK in run_at.
  • check-install-safety.sh:
    • Reap the lock-holder process when an assertion fails.
    • Add a real two-install race on the flock, beyond the held-lock case.
  • tests/lib/install-home.sh:
    • snap_tree's skip argument should prune a skipped directory's children.
    • Document that the lib owns the EXIT trap.
  • check-install-manifest.sh:
    • Field-check link records in plan mode, not only install mode.

Done when each box is checked and the four installer checks still pass under /bin/bash 3.2.

Dominant language
HTML
Stars
347
Forks
12
Avg merge
2d 16h
Merged PRs (30d)
95

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from coco-research/coco

All issues in coco-research/coco

Similar issues

More CLI issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.