roachtest/split: drop qps flavor of load-based split objective tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- go
- Domain
- databases, testing-qa
Research direction
Start in pkg/cmd/roachtest/tests/split.go at runLoadSplits and inspect the setLoadBasedRebalancingObjective helper. Remove the qps case while retaining CPU coverage, then check related expected split-count assertions. Done means the load-split objective tests remain valid with CPU-only coverage.
Written by the indexing model from the issue text.
Description
Summary:
runLoadSplits (pkg/cmd/roachtest/tests/split.go:799) parameterizes its test cases over kv.allocator.load_based_rebalancing.objective, exercising both qps and cpu. This setting is read only by the legacy StoreRebalancer and has no effect under MMA.
MMA only ever balances on CPU, so the qps flavor of these tests is dead weight once MMA is the default (per #169430). Drop it; keep CPU coverage only.
Next Steps:
- Remove the
qpsarm of the load-split objective matrix insplit.go. - Drop or simplify the
setLoadBasedRebalancingObjectivehelper if it loses its remaining caller. - Sanity-check that any related assertions (e.g. expected split counts) still hold under CPU-only.
Epic CRDB-56265
Jira issue: CRDB-63451
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- Avg merge
- 2h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cockroachdb/cockroach
-
A-cdc T-cdc X-blathers-untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
cockroachdb/cockroach#175528 · 2 comments ·
-
A-sql-console-timeseries C-bug O-agent T-observability
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
cockroachdb/cockroach#173282 · 1 comment ·
-
A-partitioning C-enhancement E-easy E-quick-win T-sql-queries
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
cockroachdb/cockroach#173103 · 2 comments ·
-
A-kv-transactions branch-master C-bug O-agent P-3 T-kv
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
cockroachdb/cockroach#172429 ·
-
kvserver/rangefeed: race-build iterator-recreation probability in CatchUpScan is loop-invariant OpenA-kv-rangefeed A-testing branch-master C-bug O-agent P-3 T-kv
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
cockroachdb/cockroach#172426 · 1 comment ·
All issues in cockroachdb/cockroach
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100