changefeedccl: remove changefeed.external_connection.apply_uri_path_and_params.enabled
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Start with pkg/ccl/changefeedccl/changefeedbase/settings.go to locate the temporary setting, then inspect isqlExternalConnectionProvider.resolve in pkg/ccl/changefeedccl/sink_external_connection.go and any nearby changefeed tests. Done means the setting and its conditional branch are removed, leaving external URI paths and query parameters always applied.
Written by the indexing model from the issue text.
Description
changefeed.external_connection.apply_uri_path_and_params.enabled was added in
#174687 as a temporary escape hatch and should be removed once it is no longer
needed.
Background
Before #174687, a changefeed sink URI of the form external://<name>/<path>
silently discarded <path>, so the feed wrote to the external connection's base
URI rather than the requested subdirectory. Query parameters on the external://
URI were discarded the same way. The fix now resolves the URI correctly https://github.com/cockroachdb/cockroach/issues/174687.
Because a changefeed re-resolves its stored external:// URI every time its sink
is built, applying the path moves where an already-running feed writes — on its
next restart, including a rolling upgrade. The setting exists so an operator
surprised by that can put the feed back on the base URI without recreating it. It
is not meant to be a long-lived knob.
Work
Delete the setting from pkg/ccl/changefeedccl/changefeedbase/settings.go and
the branch that reads it in isqlExternalConnectionProvider.resolve
(pkg/ccl/changefeedccl/sink_external_connection.go), so the path and
parameters are always applied.
Jira issue: CRDB-68433
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- Avg merge
- 2h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cockroachdb/cockroach
-
A-sql-console-timeseries C-bug O-agent T-observability
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
cockroachdb/cockroach#173282 · 1 comment ·
-
A-partitioning C-enhancement E-easy E-quick-win T-sql-queries
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
cockroachdb/cockroach#173103 · 2 comments ·
-
A-kv-transactions branch-master C-bug O-agent P-3 T-kv
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
cockroachdb/cockroach#172429 ·
-
kvserver/rangefeed: race-build iterator-recreation probability in CatchUpScan is loop-invariant OpenA-kv-rangefeed A-testing branch-master C-bug O-agent P-3 T-kv
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
cockroachdb/cockroach#172426 · 1 comment ·
-
A-kv-rangefeed branch-master C-bug O-agent P-3 T-kv
Difficulty 1/5 Under an hour Newbie friendliness 88/100
cockroachdb/cockroach#172422 ·
All issues in cockroachdb/cockroach
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100