testserver: cmd with `--log` option does not generate `listen-url` in tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 30/100
Research direction
Start with testserver_test.go and reproduce the tests using the --log configuration described in the issue, then compare that run with --logtostderr and the local CLI behavior. Trace why the cockroach command does not create the listen-url file in the test temporary directory; done means the affected tests generate listen-url with --log as they do locally.
Written by the indexing model from the issue text.
Description
After replacing --logtostderr to --log="{file-defaults: {dir: tmp/dir/to/log}, sinks: {stderr: {filter: NONE}}}" , the "cockroach" command does not generate the listen-url file in the tmp directory when running tests from testserver_test.go. But the same command works well in local CLI.
Demo of tests with original --logtostderr running in debugger: check here
Demo of tests with --log running in debugger and local CLI: check here
Demos are based on these code changes.
- Dominant language
- Go
- Stars
- 170
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cockroachdb/cockroach-go
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
cockroachdb/cockroach-go#188 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
cockroachdb/cockroach-go#185 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
cockroachdb/cockroach-go#169 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
cockroachdb/cockroach-go#166 · 4 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
cockroachdb/cockroach-go#165 ·
All issues in cockroachdb/cockroach-go
Similar issues
-
☢️ Bug v3
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area/import-export area/projects concern/ux
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
go-vikunja/vikunja#4455 · 1 comment ·
Maintainers usually reply within 2 days
-
Dependabot PRs no longer merge automaticallyPossibly taken @dwisiswant0 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
projectdiscovery/urlfinder#160 ·
Maintainers usually reply within 1 day
-
database
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
chnm/legal-modernism#450 ·
Maintainers usually reply within 1 day
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day