Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

[quality] bare /uncc by a non-collaborator (uncc.ts:79) and /milestone with no milestones (milestone.ts:66) are never driven through dist/index.js

Open
  • Is something wrong?
#454 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

@hivecommons-hive is already working on this.

Since Oct 12, 2026.

  • #455 by @hivecommons-hive — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
20/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
github-actions, typescript
Domain
backend, testing-qa

Research direction

Read __tests__/bundle/collaborationCommands.test.ts and __tests__/bundle/closeMilestone.test.ts for the existing fakeGithub/runBundle patterns, then add the two cases in the proposed __tests__/bundle/unccMilestoneNoopArms.test.ts. Run npm run test:coverage:e2e; done means both cases pass and the uncc.ts and milestone.ts branches reach 100%.

Written by the indexing model from the issue text.

Description

agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5q9t needs-kind quality testing

Finding

Two quiet arms are unit-covered but never exercised by the bundle (end-to-end) suite:

  • src/issueComment/uncc.ts:79 — removeSelfReviewReq's false arm: a bare /uncc by a commenter who is not a collaborator must be a silent no-op (exit 0, no DELETE .../requested_reviewers). __tests__/bundle/collaborationCommands.test.ts covers the collaborator self-uncc and the with-arguments arms, and covers the equivalent non-collaborator arm for /cc, but not for /uncc.
  • src/issueComment/milestone.ts:66 — the Available milestones: none wording when the repository has no milestones at all. __tests__/bundle/closeMilestone.test.ts only reaches the not-found message with a non-empty title list.
Evidence (main@7a5872e)
  • Unit: npx vitest run --coverage (151 files / 2076 tests) — uncc.ts and milestone.ts both 100% statements/branches/lines.
  • End-to-end: npm run test:coverage:e2e (local, .coverage-bundle remapped onto src/) — uncc.ts branches 88.88% (uncovered line 79), milestone.ts branches 92.3% (uncovered line 66). Overall e2e: 99.32% statements, 95.37% branches (1588/1665).
  • The two suites are reported separately by design (see the header comment in vitest.e2e-coverage.config.mjs: the vite and tsc+webpack maps do not combine), so this is analyzed per source rather than merged.

Recommendation

Add one bundle test file, __tests__/bundle/unccMilestoneNoopArms.test.ts, with two cases driven through dist/index.js via the existing fakeGithub/runBundle harness:

  • /uncc (no arguments) with GET /collaborators/Codertocat → 404: run exits 0, no errors, the only call is the collaborator read, no DELETE is issued.
  • /milestone v1.0 with GET /milestones → []: run exits 1 with milestone "v1.0" not found. Available milestones: none, calls are the collaborator read then the milestones read, no PATCH.

With both cases, uncc.ts and milestone.ts report 100% under test:coverage:e2e (branches 1588 → 1590 / 1665).

Priority

  • Impact: low (defensive no-op and message wording arms; both already unit-tested)
  • Effort: low

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 7a5872e

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Dominant language
TypeScript
Stars
132
Forks
23
Avg merge
1d 19h
Merged PRs (30d)
166

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cncf/prow-github-actions

All issues in cncf/prow-github-actions

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.