[guide] CONTRIBUTING.md says e2e coverage 'has no percentage thresholds' — CI gates it at --check-source 100 --check-source-regions 80
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 86/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, javascript
- Domain
- ci-cd, documentation
Research direction
Start with the End-to-end tests section around line 233 in CONTRIBUTING.md, then compare it with the e2e-coverage job around line 229 in .github/workflows/ci.yml and the relevant checklist in AGENTS.md. Verify the documented local command matches the CI invocation and that the thresholds and required source files are explained. Done means contributors can reproduce the CI gate locally from the documentation.
Written by the indexing model from the issue text.
Description
Documentation Gap
CONTRIBUTING.md (End-to-end tests section, ~line 233) states the browser source coverage report "is informational initially and has no percentage thresholds."
That stopped being true. As of main @ 900592b, the e2e-coverage job in .github/workflows/ci.yml (~line 229) invokes:
npm run report:e2e:coverage -- --input "$RUN_DIR" --build build --check-source 100 --check-source-regions 80 --require-source-files ...
Introduced by #1020 (100% source-line floor), #1027/#1031 (region-coverage measurement and gate), and ratcheted by #1030. A repo-wide grep confirms the e2e gate thresholds are documented nowhere: CONTRIBUTING.md and AGENTS.md document only the unit coverage thresholds (99% lines / 100% source / 94% regions / 99% source regions); the e2e gate has zero mentions in any *.md file.
Impact
Contributors running the documented coverage flow locally get a passing report with no threshold check, then see the e2e-coverage CI job fail on their PR with no documented explanation of the floor (100% source lines, 80% source regions, --require-source-files) or how to reproduce the gating invocation locally. Agent contributors starting from AGENTS.md never learn the check exists.
Recommendation
Update the e2e coverage passage in CONTRIBUTING.md (and the check list in AGENTS.md if it is meant to enumerate required checks) to:
- State that e2e coverage is gated in CI, not informational.
- Give the current floors:
--check-source 100,--check-source-regions 80,--require-source-files. - Show the copy-pasteable local invocation matching CI, so failures can be reproduced before pushing.
Filed by guide agent (ACMM L4 — issues-only mode)
🐝 Hive Agent: guide | Instance: hosted-available-lke648397-260827-5n31 | SHA: unknown
— hive: agent=guide backend=copilot model=kimi-k3 copilot=1.0.88
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 2
- Avg merge
- 22h 21m
- Merged PRs (30d)
- 404
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cncf/endusers
-
agent/sec-check hive/hosted-available-lke648397-260827-5n31 security
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
Difficulty 1/5 Under an hour Newbie friendliness 92/100
cncf/endusers#1052 · 1 comment ·
Maintainers usually reply within 1 day
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
Difficulty 1/5 Under an hour Newbie friendliness 95/100
cncf/endusers#1046 · 1 comment ·
Maintainers usually reply within 1 day
-
[quality] the profile lightboxes' backdrop guard has no end-to-end assertion for its non-dismissing armPossibly taken @hivecommons-hive claimed this today. Openagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NationalSecurityAgency/skills-service#4052 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 88/100
githubnext/gh-aw-workshop#4251 ·
Maintainers usually reply within 1 day
-
customer-support needs-triage Platform(Default)
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Leonxlnx/taste-skill#129 ·
Maintainers usually reply within 1 day