suggestion for aws.ec2metadata::instance_document
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
Research direction
Start by locating instance_document and tracing how it handles the result of get_instance_metadata(item = "dynamic/instance-identity/document") before calling jsonlite::fromJSON. Decide how the function should handle a NULL response, then check its existing tests or add coverage for that case. Done when a missing metadata document returns NULL or produces a clearer error instead of the cryptic JSON parsing error.
Written by the indexing model from the issue text.
Description
aws.ec2metadata:::get_instance_metadata(item = "dynamic/instance-identity/document") can return NULL, but when this happens, the NULL is passed to jsonlite::fromJSON resulting in a cryptic error "Argument 'txt' must be a JSON string, URL or file."
Instead in such cases, it might be better to allow aws.ec2metadata::instance_document to return NULL, or at least give a more informative error message.
Thank you for considering.
- Dominant language
- R
- Stars
- 12
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cloudyr/aws.ec2metadata
-
Update releases?Open
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
cloudyr/aws.ec2metadata#15 ·
All issues in cloudyr/aws.ec2metadata
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
tidyverse/ellmer#1226 · 1 comment ·
Maintainers usually reply within 3 days
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
tylermorganwall/rayshader#352 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Open-Systems-Pharmacology/OSPSuite.ParameterIdentification#377 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100