`cloudName` required unnecessarily
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- api
Research direction
Read src/assets/CloudinaryFile.ts around lines 182-193 and src/internal/url/cloudinaryURL.ts around lines 20-51, then trace how getUrlPrefix handles secureDistribution and privateCDN. Move the cloud-name validation to the relevant URL-prefix branches so omission is rejected only when needed.
Written by the indexing model from the issue text.
Description
In https://github.com/cloudinary/js-url-gen/blob/e1b97191fff165b6ecb353acb2477cc25a062667/src/assets/CloudinaryFile.ts#L182-L193 a cloudName setting is explicitly required. However, in https://github.com/cloudinary/js-url-gen/blob/e1b97191fff165b6ecb353acb2477cc25a062667/src/internal/url/cloudinaryURL.ts#L20-L51 the cloudName isn't actually even utilized if using a secureDistribution and privateCDN.
The check for cloudName should be moved into getUrlPrefix and we should only throw when omitting the cloud name for branches where it's actually utilized.
- Dominant language
- HTML
- Stars
- 56
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cloudinary/js-url-gen
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
cloudinary/js-url-gen#608 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
cloudinary/js-url-gen#606 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
cloudinary/js-url-gen#600 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
cloudinary/js-url-gen#587 · 4 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
cloudinary/js-url-gen#572 · 1 comment ·
All issues in cloudinary/js-url-gen
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
openwisp/openwisp-monitoring#889 ·
Maintainers usually reply within 2 days
-
Old /download.php attachment links: redirect drops the subfolder, nginx.example.conf returns 404OpenBug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
IsTextFile reads the whole file into memory (OOM on large files in the file watcher)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gtsteffaniak/filebrowser#3395 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
area: csp area: css area: http-headers area: web ui bug difficulty: easy frontend good first issue help wanted javascript journey: first-visit priority: P3 quality tech: css tech: html typescript ui user-experience
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day