Upload API throws RuntimeException
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
Research direction
Start by locating the upload method whose signature declares IOException and trace the cases that currently throw RuntimeException. The issue leaves the final error-handling design open; done requires a consistent caller-identifiable error mechanism, with its behavior documented and verified for the affected cases.
Written by the indexing model from the issue text.
Description
Hello,
You should provide an easy way to handle upload errors in your SDK.
The method signature suggests that you will be throwing an IOException but looking at the source code, we can see that you're actually throwing RuntimeException in several cases ! These cases should be handled differently in the SDK so that the caller can identify them : they are definitely not a reason to throw a RuntimeException.
At the minimum, you should throw a IOException as specified by the upload signature.
Alternatively, you could think about a nicer error handling system, either with a custom Exception or with a specific Map returned (whose values should be documented !).
- Dominant language
- Java
- Stars
- 176
- Forks
- 113
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cloudinary/cloudinary_java
-
`options` map modified directlyMay be free again @adimiz1 claimed this 481 days ago, and no pull request is open. Open
cloudinary/cloudinary_java#383 · 3 comments · 1 reaction · 1 assignee ·
-
Api#resourceByAssetID does not support same options as in documentationMay be free again @adimiz1 claimed this 647 days ago, and no pull request is open. Open
cloudinary/cloudinary_java#357 · 2 comments · 1 assignee ·
-
Readme - Maven dependencyMay be free again @adimiz1 claimed this 754 days ago, and no pull request is open. Open
cloudinary/cloudinary_java#349 · 1 comment · 1 assignee ·
-
cloudinary-http5 ignores system propertiesMay be free again @adimiz1 claimed this 754 days ago, and no pull request is open. Open
cloudinary/cloudinary_java#348 · 2 comments · 1 assignee ·
-
Make usage of http clients (apache, OkHttp, Jetty, Asynch) easierMay be free again @ManishS6 claimed this 772 days ago, and no pull request is open. Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
cloudinary/cloudinary_java#343 · 6 comments ·
All issues in cloudinary/cloudinary_java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Backblaze/b2-sdk-java#248 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
IETF-Hackathon/pqc-certificates#351 ·
Maintainers usually reply within 2 days
-
hermes-queue
Difficulty 2/5 Under an hour Newbie friendliness 72/100
chrisalunlloyd2-sudo/mindpalace#393 ·
Maintainers usually reply within 1 day