Tags with special URI characters are not readable

Open
  • Is something wrong?
#299 1 comment 0 reactions 1 assignee View on GitHub

@aleksandar-cloudinary is already working on this.

Since Nov 12, 2019.

Assessment

This issue has not been assessed yet.

Description

bug

Tags that contain non-uri-component-safe characters are not readable using the resources_by_tag method. Example:

tag = 'with/some?bad=characters'
Cloudinary::Uploader.upload(url, tags: [tag]) # correctly encodes value

# will not see the upload
Cloudinary::Api.resources_by_tag(tag) 
# because uri = "resources/#{resource_type}/tags/#{tag}"

# Work around, will see the upload
Cloudinary::Api.resources_by_tag(URI.encode_www_form_component(tag))

This looks to be caused by assembling the URI without encoding.

I'm opening an issue rather than a pull request because the code seems to have a lot of direct URI assembling, so the issue almost certainly exists elsewhere in the code. Most sites seem to have more constrained elements (type, public_id, etc.), but it does not hurt to encode them too.

Dominant language
Ruby
Stars
420
Forks
282
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cloudinary/cloudinary_gem

All issues in cloudinary/cloudinary_gem

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.