`cf workers secrets bulk` silently no-ops on the plain body shape; `secrets update` accepts invalid names
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
Research direction
Start by reproducing the documented cf workers secrets bulk and secrets update commands, then trace the workers secrets command, help, and schema paths. Compare plain and wrapped bodies, .env input, and invalid names; done means the behavior is explicit, the body shape is documented in help and schema, and invalid names are rejected locally.
Written by the indexing model from the issue text.
Description
cf version: 1.0.0-beta.5, macOS
1. cf workers secrets bulk silently does nothing with the plain (RFC 7396 merge-patch) body.
cf workers secrets bulk --worker W --body '{"API_KEY":{"type":"secret_text","text":"v"}}'
This returns 200 and exits 0, and the response lists the bindings, but the secret's value doesn't change (checked for 20 s). Only the wrapped shape {"secrets":{"API_KEY":{...}}} applies it.
--filewith the plain shape: the same silent no-op.--filewith a.envfile:[10026] Could not parse request body.--helpdoesn't show the body shape, andcf schema workers secrets bulkshowsrequestBodyFields: [].
2. cf workers secrets update accepts invalid names. cf workers secrets update "bad-name!" --worker W --type secret_text --text v creates the secret (exit 0), although the help says the name must be "A JavaScript variable name". It can only be removed with delete "bad-name!" -f.
Expected: reject a body that won't apply, or accept the plain shape; document the body in --help and the schema; validate secret names locally.
Related, but a different problem: #96 (secrets update replaces the whole set).
Found while evaluating cf for a dev workflow: https://github.com/joeblew999/cf-cli-test (FINDINGS.md, findings/).
- Dominant language
- TypeScript
- Stars
- 916
- Forks
- 53
- Avg merge
- 18h 31m
- Merged PRs (30d)
- 172
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cloudflare/cf
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
cloudflare/cf#344 ·
Maintainers usually reply within 1 day
-
upstream
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cloudflare/cf#262 ·
Maintainers usually reply within 1 day
-
`cf dev` rejects `--port` and `--host` for Vite projects, including the `cf init` templatePossibly taken @jamesopstad claimed this 8 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cloudflare/cf#223 · 2 assignees ·
Maintainers usually reply within 1 day
-
upstream
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cloudflare/cf#179 ·
Maintainers usually reply within 1 day
-
upstream
Difficulty 4/5 3-5 days Newbie friendliness 58/100
cloudflare/cf#347 ·
Maintainers usually reply within 1 day
Similar issues
-
agent/scanner help wanted hive/claimed-by-scanner kind/bug stage/020-claimed
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
hivecommons/rationguard#315 ·
Maintainers usually reply within 1 day
-
agent-ready area: ui-sdk priority: p3 type: chore
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
schlessera/brain-kit#2534 ·
Maintainers usually reply within 1 day
-
bug lane:gh-5
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
LLM-4-People/bridlewise-testing#122 ·
Maintainers usually reply within 1 day
-
bug priority: P2
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
enhancement priority:low ready-for-dev
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day