Avro compact deserializer bug - ID set to type
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start with formats/avro-compact/src/main/java/io/cloudevents/avro/compact/AvroCompactFormat.java around line 90, then inspect the related test at formats/avro-compact/src/test/java/io/cloudevents/avro/compact/AvroCompactFormatTest.java around line 46. Update the ID handling as indicated and use different type and ID values in the test so the bug is detected; run the Avro compact format tests to confirm the fix.
Written by the indexing model from the issue text.
Description
Looks like accidental set of ID to type.
https://github.com/cloudevents/sdk-java/blob/main/formats/avro-compact/src/main/java/io/cloudevents/avro/compact/AvroCompactFormat.java#L90
Should be:
.withId(from.getId())
Test should be fixed as well. Using different values in type and ID of the test event would detect the issue.
https://github.com/cloudevents/sdk-java/blob/main/formats/avro-compact/src/test/java/io/cloudevents/avro/compact/AvroCompactFormatTest.java#L46
- Dominant language
- Java
- Stars
- 446
- Forks
- 172
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cloudevents/sdk-java
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cloudevents/sdk-java#731 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cloudevents/sdk-java#689 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
cloudevents/sdk-java#660 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
cloudevents/sdk-java#748 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
cloudevents/sdk-java#711 · 1 comment ·
All issues in cloudevents/sdk-java
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Two open-case totals on one screen: the Programs tile says 15,858 and the nav badge says 15,868 Openbug frontend maui-pilot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
objectionary/eo-graphs#74 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100