JsonFormat doesn't accept valid datacontentypes

Open Beginner friendly
#660 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
api

Research direction

Start by locating JsonFormat and its JSON_CONTENT_TYPE_PATTERN, then inspect the surrounding validation and any related tests. Update the validation so registered media types such as vnd.hal+json are accepted, and confirm the existing valid and invalid content-type cases still behave correctly.

Written by the indexing model from the issue text.

Description

The JSON_CONTENT_TYPE_PATTERN in JsonFormat is too restrictive: valid registered media-types like https://www.iana.org/assignments/media-types/media-types.xhtml e.g. vnd.hal+json is not accepted.

Dominant language
Java
Stars
446
Forks
172
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cloudevents/sdk-java

All issues in cloudevents/sdk-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.