'Thread' object has no attribute 'isAlive'

Open Beginner friendly
#328 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Open pattern/web/init.py and inspect the done property around line 224, then run the asynchronous requests example described in the issue. Update the outdated thread method and verify that request completion no longer raises AttributeError.

Written by the indexing model from the issue text.

Description

Hi!

In "/usr/local/lib/python3.9/site-packages/pattern/web/init.py" we have isAlive() in line 224. Running the asynchronous requests example from pattern web it throws:

Traceback (most recent call last):
File "/Users/eyoshi/Python/Pattern/pattern_web_example.py", line 20, in
while not request.done:
File "/usr/local/lib/python3.9/site-packages/pattern/web/init.py", line 224, in done
return not self._thread.isAlive()
AttributeError: 'Thread' object has no attribute 'isAlive'

isAlive needs to be changed to is_alive() here.

Dominant language
Python
Stars
8.9k
Forks
1.6k
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from clips/pattern

All issues in clips/pattern

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.