BUG: new clerk.enterprise_connections.create returns `Unset()` instead of empty values

Open Beginner friendly
#227 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
api

Research direction

Start by reproducing clerk.enterprise_connections.create and inspect its returned fields, then compare the result with clerk.saml_connections.create. The fix is complete when idp_sso_url and idp_entity_id no longer expose Unset() or its sentinel to callers and the response provides the expected empty values.

Written by the indexing model from the issue text.

Description

We just upgrade our Python SDK to the latest and migrate our previous clerk.saml_connections.create to clerk.enterprise_connections.create and returned the success response to our UI.

After the migration our UI was showing some strange values for idp_sso_url and idp_entity_id: ~?~unset~?~sentinel~?~

After a quick debug I noticed the return from the new enterprise connection method is:

id='samlc_...', name='ASDF - Microsoft', idp_entity_id=Unset(), idp_sso_url=Unset(), idp_metadata_url=Unset(), ...
Dominant language
Python
Stars
186
Forks
47
Avg merge
18h 43m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from clerk/clerk-sdk-python

All issues in clerk/clerk-sdk-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.