cartographer-project/cartographer

Investigate and fix issues compiling Cartographer with gRPC support.

Open

#1,894 opened on Jul 16, 2022

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C++ (6,665 stars) (2,188 forks)batch import
bughelp wanted

Description

TL;DR: Best approach could be to target Ubuntu 22.04, install the deb package libgrpc++-dev and fix further build issues.

Right now Dockerfile.bionic.grpc fails when running cartographer/scripts/install_grpc.sh with output like this:

make
/bin/sh: 0: Illegal option -t
/bin/sh: 0: Illegal option -t
/bin/sh: 0: Illegal option -t
/bin/sh: 0: Illegal option -g
/bin/sh: 0: Illegal option -g

Using newer versions of Ubuntu or gRPC produces the same issue it seems. But since Ubuntu 22.04 ships with a package for gRPC, we might be able to use this instead, with no need to look into build issues of gRPC.

Using this approach still does not unbreak the full Cartographer build, but now fails building async_grpc which is part of Cartographer and has linker errors for its tests, but these issues seem unrelated to gRPC.

Contributor guide

Tech stack
cppgrpcdockershell
Domain
build systemdevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++DockergRPCLinux command line
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine Dockerfile.bionic.grpc and install grpc.sh to understand the current build process. Test the suggested approach of using Ubuntu 22.04 and installing libgrpc++ dev. Fix any resulting linker errors in the async grpc module and verify tests pass.
Investigate and fix issues compiling Cartographer with gRPC support. · cartographer-project/cartographer#1894 | Good First Issue