Type check scripts/scan-txlog with mypy --strict
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by reading scripts/check-python-types.sh and scripts/python-locations.sh to see how the scripts are checked and excluded. Then inspect scripts/scan-txlog and scan_txlog.py, run mypy with --strict, and work through the reported errors, checking the name-defined findings for real bugs. Done means the script is included in python_pathspecs, the exclusions are removed, strict type checking passes, and the lack of unit tests has been considered.
Written by the indexing model from the issue text.
Description
Part of #7987. scripts/scan-txlog is excluded from scripts/check-python-types.sh because it has about 1300 --strict errors (mostly missing annotations, plus ~75 name-defined that may be real bugs; scan_txlog.py alone has ~950).
Annotate it, then add it to python_pathspecs in scripts/python-locations.sh and remove the exclusions there. It also has no unit tests yet.
- Dominant language
- Scala
- Stars
- 118
- Forks
- 125
- Avg merge
- 22h 35m
- Merged PRs (30d)
- 340
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from canton-network/splice
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
canton-network/splice#8142 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
canton-network/splice#8087 ·
Maintainers usually reply within 1 day
-
Fix list of SVs in the SV UI historical proposal detailsMay be free again @loglapa claimed this 7 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
canton-network/splice#7939 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
canton-network/splice#6641 · 5 comments ·
Maintainers usually reply within 1 day
-
now
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
canton-network/splice#6500 ·
Maintainers usually reply within 1 day
All issues in canton-network/splice
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
svroonland/zio-kinesis#1431 ·
-
area:build priority:P2 status:backlog
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
KD5UJC-XYZ/scarab#648 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
lichess-org/lila#22324 · 3 comments ·
Maintainers usually reply within 1 day
-
area:ci enhancement priority:low requires-triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
apache/datafusion-comet#7319 · 1 comment ·
Maintainers usually reply within 1 day