Wait after resetting config in example charm integration tests?
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 43/100
Research direction
Read the integration tests in examples/machine-tinyproxy/tests/integration/test_charm.py and examples/httpbin-demo/tests/integration/test_charm.py, especially the config reset and juju.wait() calls. Decide whether to add a wait in both examples; done means the tutorial’s claim about the charm returning to an unblocked state is accurate, and the tests reflect the decision.
Written by the indexing model from the issue text.
Description
The final machine-tinyproxy integration test resets config:
In the tutorial we say:
[This is to] ensure that any subsequent test could assume an unblocked charm.
But that's not entirely accurate. We don't wait for the charm to go active again, so a (hypothetical) next test ought not to assume an unblocked charm.
I think we copied the approach from httpbin-demo:
When I wrote the machine charm tutorial, I incorrectly positioned the reset as a guarantee.
This needs a decision before a PR: Is it worth adding one more juju.wait() (in both charms) for the benefit of a test that doesn't exist? I lean towards yes, for the teaching value of the tutorial.
- Dominant language
- Python
- Stars
- 267
- Forks
- 156
- Avg merge
- 5d 3h
- Merged PRs (30d)
- 43
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from canonical/operator
-
tests
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 3 days
-
rainy day small item
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
Maintainers usually reply within 3 days
-
Cleaning up inconsistencies in the Manage relations how-to pagePossibly taken @tromai claimed this 1 day ago. Opendocs roadmap
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
canonical/operator#2688 · 3 comments · 1 assignee ·
Maintainers usually reply within 3 days
-
docs rainy day tests
Difficulty 3/5 1-2 days Newbie friendliness 56/100
canonical/operator#2952 · 1 reaction ·
Maintainers usually reply within 3 days
-
rainy day
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 3 days
All issues in canonical/operator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
abetlen/llama-cpp-python#2424 ·
Maintainers usually reply within 1 day
-
Bug IronPython Python 3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pyrevitlabs/pyRevit#4184 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 74/100
jqueryscript/awesome-claude-code#1009 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
[Plugin] 群聊记忆 · 人格养成Open
Difficulty 1/5 1-3 hours Newbie friendliness 74/100