Review / GF specs

Open
#36 30 comments 0 reactions 2 assignees View on GitHub

@emmamarichal is already working on this.

Since Sep 21, 2026.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Domain
design

Research direction

Start with the glyphs file and the Google Fonts Axis Registry, using the linked Playfair config and GF variable-font guide as references. Investigate whether YTAS=720 is an accepted fallback; completion means resolving that value and confirming the remaining font review requirements are satisfied.

Written by the indexing model from the issue text.

Description

Hi @MarkFonts, here you can find my last review!

OUTLINES:
  • Only Cal Sans ⚠️ WARN Detect any interpolation issues in the font. CalSans-Italic[GEOM,SHRP,YTAS,opsz,wght].pdf

  • 🔥 FAIL Check if each glyph has the recommended amount of contours. (xi (U+03BE) and uni2215 are empty and should be drawn)

GLYPHSET:
  • ⚠️ WARN Does the font contain a soft hyphen? (you can simply remove it)
  • ⚠️ WARN Font has correct separator glyphs? (easy to fix: add U+2028 and U+2029)
SPACING:
  • ⚠️ WARN Check base characters have non-zero advance width. (U+200D, U+200C, U+200B have non-zero advance width)
NAMING:
  • 🔥 FAIL Check font names are correct (since variable font origin = Regular, we don't need name ID16 and 17, but it should be solve if you use gftools builder)
  • 🔥 FAIL Check family name for GF Guide compliance. ("Cal Sans Text UI" contains an abbreviation.) @davelab6 is it ok to make an exception? Otherwise I suggest to simply call it Cal Sans Text.
  • 🔥 FAIL Validate STAT particle names and values match the fallback names in GFAxisRegistry. (On the font variation axis 'opsz', the name 'Micro' is not among the expected ones (6pt, 8pt, 18pt, 17pt, 72pt, 120pt, 16pt, 11pt, 9pt, 14pt, 28pt, 48pt, 60pt, 96pt, 12pt, 20pt, 36pt, 24pt, 7pt, 144pt, 10pt) according to the Google Fonts Axis Registry. Same for the other styles. You can follow Playfair example.
V-METRICS:
  • 🔥 FAIL Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
  • 🔥 FAIL Checking OS/2 usWinAscent & usWinDescent
  • 🔥 FAIL Checking OS/2 Metrics match hhea Metrics. (OS/2 sTypoAscender (900) and hhea ascent (1024) must be equal and OS/2 sTypoLineGap (55) and hhea lineGap (0) must be equal.)
  • 🔥 FAIL Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN Checking Vertical Metric linegaps. (OS/2 sTypoLineGap is not equal to 0)

Here are the v-metrics to use, it will solve all the FAILS/WARNS related (these are the current Cal Sans ones, we can't change them, except Win ones):

TypoAscender = 1000
TypoDescender = -300
TypoLineGap = 0
hheaAscent = 1000
hheaDescent = -300
hheaLineGap = 0
WinAscent = 1029
WinDescent = 283
FONT INFOS / INSTANCES / STAT:
  • Only Cal Sans 🔥 FAIL Validate defaults on fvar table match registered fallback names in GFAxisRegistry. (The defaul value YTAS:720 is not registered as an axis fallback name on the Google Axis Registry. You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis: 750)
  • 🔥 FAIL Check variable font instances (Currently, the Italic version of variable has styles without italic name)
  • 🔥 FAIL Validates subfamilyNameID and postScriptNameID for the default instance record
  • ⚠️ WARN Ensure 'opsz' axis values are not marked as elidable in STAT. (STAT table 'opsz' axis value '14' and 45 is marked as elidable. Optical size values should not be elidable.)
  • ⚠️ WARN Ensure VFs have 'ital' STAT axis.
  • ⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (add the parameter 'meta table' in font infos.)

TO DO: 1st Priorities

  • Update V-metrics with the above values
  • Build with gftools builder or remove ID16 and ID17
  • Fix the interpolation issue
  • Draw the two missing glyphs (xi (U+03BE) and uni2215)
  • Check with @davelab6 and @aaronbell if Cal Sans Text UI name is ok (abbreviation exception)
  • Rename opsz styles according GF specs (see Playfair + our guide https://googlefonts.github.io/gf-guide/variable.html#opsz
  • Check if you can use YTAS = 720 (I'll investigate on my side)
  • In glyphs file, you have to set up and activate the following instances only, it's the FVAR. (Currently, the Italic version of variable has styles without italic name)
Regular
Medium
SemiBold
Bold

Italic
Medium Italic
SemiBold Italic
Bold Italic
Dominant language
Python
Stars
1.8k
Forks
55
Avg merge
1d 27m
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from calcom/sans

All issues in calcom/sans

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.