Missing German translations in incident.php

Open Beginner friendly
#466 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
90/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
laravel, php
Domain
localization

Research direction

Start with vendor/cachethq/core/resources/lang/de/incident.php and compare its incident timeline keys with the labels referenced in the issue. Add the German entries for from_label and to_label, then verify the incident timeline displays “Von” and “Bis” when APP_LOCALE and APP_FALLBACK_LOCALE are set to de.

Written by the indexing model from the issue text.

Description

Hello everybody,

after installing cachet 3x and using following environment variables

APP_LOCALE = de
APP_FALLBACK_LOCALE = de
APP_FAKER_LOCALE = de_DE

cachet::incident.timeline.from_label
and
cachet::incident.timeline.to_label

are shown instead of the correct German translation.

Image

A possible fix is to add from_label and to_label below line 20 in vendor/cachethq/core/resources/lang/de/incident.php:
20 'no_incidents_reported_between' => 'Keine Vorfälle gemeldet zwischen :from und :to',
21 'from_label' => 'Von',
22 'to_label' => 'Bis',
23 'navigate' => [
24 'previous' => 'Vor',

changes.patch

Best regards
Alexander

Dominant language
PHP
Stars
228
Forks
84
Avg merge
11h 19m
Merged PRs (30d)
22

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cachethq/core

All issues in cachethq/core

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.