global.data
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- devtools
Research direction
Search the agent for where global.data is created and how the Runtime.evaluate request is handled. Read the surrounding global-state and console integration code, then determine whether the object can be kept private or removed without breaking the agent. Done means global.data is no longer exposed unintentionally and the relevant behavior is verified.
Written by the indexing model from the issue text.
Description
Hi, I was looking at global objects and I've found the global.data object.
{"method":"Runtime.evaluate","params":{"expression":"JSON.stringify(global.data)","objectGroup":"console","includeCommandLineAPI":true,"doNotPauseOnExceptionsAndMuteConsole":false,"returnByValue":false,"generatePreview":true},"id":82}
I suppose it is node-webkit-agent specific. Can't it be kept private?
I have no time now to clean it, but I recommend not to use globals if not strictly necessary.
Do you agree?
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 77
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from c4milo/node-webkit-agent
-
Difficulty 4/5 3-5 days Newbie friendliness 15/100
c4milo/node-webkit-agent#87 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 18/100
c4milo/node-webkit-agent#84 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
c4milo/node-webkit-agent#83 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
c4milo/node-webkit-agent#81 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
c4milo/node-webkit-agent#78 · 12 comments ·
All issues in c4milo/node-webkit-agent
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·