Feature Request :: programmatic support for named profiles

Open
#52 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript, node.js
Domain
performance

Research direction

Start in lib/profiler.js at the Profiler start function and compare it with lib/v8-profiler.js at startProfiling. Trace the existing programmatic start path, then verify that a name supplied in the options reaches startProfiling and is used for the resulting profile.

Written by the indexing model from the issue text.

Description

I can programmatically start and stop profiling using constructions like this:

    agent.loadedAgents["Profiler"].start({}, () ->)

The v8-profiler startProfiling function supports providing a name for a profile, but the Profiler start function doesn't provide a way to pass a name to startProfiling. I'd like to be able to do

    agent.loadedAgents["Profiler"].start({name: "my-profile-name"}, () ->)

and have that name passed along.

Dominant language
JavaScript
Stars
1.1k
Forks
77
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from c4milo/node-webkit-agent

All issues in c4milo/node-webkit-agent

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.