Investigate using Clippy and following lints' recommendations

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
compilers

Research direction

Review the discussion in pull request #1, especially the linked review and issue comments, to understand which Clippy recommendations are questionable for this register allocator. Run Clippy on the project, assess which lints are appropriate, and clean up the applicable findings. Done means the selected lints are addressed or explicitly justified.

Written by the indexing model from the issue text.

Description

In this comment it was suggested that we run Clippy and follow its lints. It seems that this is somewhat nontrivial as at least some of its lints seem questionable in our particular case but we should spend the time to look into which particular lints may make sense to enable and clean up our code as necessary.

Dominant language
Rust
Stars
266
Forks
54
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bytecodealliance/regalloc2

All issues in bytecodealliance/regalloc2

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.